Chirag 🇮🇳

Smart contract developer & web3 writer

[Chirag 🇮🇳 @0xcsp]

@systemdesignone Playbook

[Chirag 🇮🇳 @0xcsp]

@livingdevops Terraform

[Chirag 🇮🇳 @0xcsp]

@serverConnectd @calyptus_web3 Without "pure/view" you can't get the return value offchain. It will be treated as a transaction. You pay 21000 extra gas which is minimum amount of gas to pay for tx.

[Chirag 🇮🇳 @0xcsp]

@calyptus_web3 Make function pure. It will return (0x12,0x12340000)

[Chirag 🇮🇳 @0xcsp]

@serverConnectd @calyptus_web3 Which part ser?

[Chirag 🇮🇳 @0xcsp]

@calyptus_web3 uint256, address, uint40, uint8, string

[Chirag 🇮🇳 @0xcsp]

@SBinaykiya No event emitted?

[Chirag 🇮🇳 @0xcsp]

@Quill_Academy 2nd loop because ++i is cheaper than i++. In addition to that, replace i=0; with i; and use unchecked block to increment i

[Chirag 🇮🇳 @0xcsp]

@PopPunkOnChain 🤚

[Chirag 🇮🇳 @0xcsp]

@SBinaykiya @AdarshS002 if (bugCount < 3) revert UnderflowError();

[Chirag 🇮🇳 @0xcsp]

@_PolkadotIndia Try now

[Polkadot India @_PolkadotIndia]

👨‍💻 100 Developer Jobs Across Polkadot Ecosystem 👨‍💻

Bear Market? Nah, not for #Polkadot

Polkadot has the highest development activity in June 2023! 📊

It's always a bull for Polkadot Builders! 🛠️📈

Get this list ASAP: please 👍 Like, 🔁 Retweet, & 🗨️ Comment "Polkadot"

[Chirag 🇮🇳 @0xcsp]

@SolidityScan Should be 'addresses[i].call'
Not checking value 'ok'
The transaction can exceed the block gas limit and revert if the 'balances' array is too large. This makes 'distribute' function unusable
'addresses[i]' can return large amount of data and make the transaction run out of gas.

[Chirag 🇮🇳 @0xcsp]

@calyptus_web3 amount 4. 1**18 = 1 wei

[Chirag 🇮🇳 @0xcsp]

@SBinaykiya Also, since transfer() limits forwarded gas to 2300 gas, sending eth to multisig will not work.

[Chirag 🇮🇳 @0xcsp]

@SBinaykiya No, reentrancy is not possible because only the owner can call withdraw(), and the transfer() function imposes a hardcoded limit of 2300 gas, which is only enough to transfer eth and emit an event.

The bug, however, is not following the Check-Effects-Interaction pattern.

[Chirag 🇮🇳 @0xcsp]

@Quill_Academy In changeHokage function _hokage should be _newHokage
No need for "currentHokage" function, since "hokage" is public, the comliler provides getter function or make "hokage" private.

[Chirag 🇮🇳 @0xcsp]

@Quill_Academy Bugs find no Jutsu
Anyone can become hokage, even someone who is not a shinobi.
Anyone can read storage slot 1 and get the value of "seal".
No access control on changeHokage.
Spelling mistake in "funciton changeHokage".