Bitcoin Core PR Reviews

A club for learning, discussing, and reviewing Bitcoin Core PRs together on IRC. See for more!

[Bitcoin Core PR Reviews @BitcoinCorePRs]

Check out the guide before the meeting to get a headstart. Real chad(ette)s squash bugs for breakfast. https://t.co/dLaNndUBrb

[Bitcoin Core PR Reviews @BitcoinCorePRs]

We're back with a special Review Club edition! @SebastianvStaa is walking us through some of the big changes in the upcoming Bitcoin Core v31 release, and how you can test them.

[Bitcoin Core PR Reviews @BitcoinCorePRs]

We've also got a few new and updated RPCs, something that sounds like assmap even though it's not written that way, and a higher default `-dbcache` value because when is a better time for that than a prolonged period of global RAM shortage.

[Bitcoin Core PR Reviews @BitcoinCorePRs]

Spin up your fuzzing engines! In approx 1.5h, @macrohead7 will walk us through new compact block testing code.

https://t.co/L7Qcc71aZe

[Bitcoin Core PR Reviews @BitcoinCorePRs]

This week's review club PR is #31363, "Cluster mempool: introduce TxGraph", authored by @pwuille and hosted by @glozow.

Notes and questions are available on the website, including a gentle introduction to cluster mempool and mempool architecture:
https://t.co/7Y856dlnCc

[Bitcoin Core PR Reviews @BitcoinCorePRs]

Logs from today's meeting are up: https://t.co/x1bYKYSpWJ
We will have a second meeting tomorrow at 17 UTC, continuing review on the same PR.

[Bitcoin Core PR Reviews @BitcoinCorePRs]

This week's review club PR is "p2p: track and use all potential peers for orphan resolution", authored + hosted by @glozow. We'll discuss logic for tx download: handling missing UTXOs, avoiding censorship, and being bandwidth-efficient.

Beginners welcome!
https://t.co/x1bYKYSpWJ

[Bitcoin Core PR Reviews @BitcoinCorePRs]

This week's review club PR is "p2p: track and use all potential peers for orphan resolution", authored + hosted by @glozow. We'll discuss logic for tx download: handling missing UTXOs, avoiding censorship, and being bandwidth-efficient.

Beginners welcome!
https://t.co/x1bYKYSpWJ

[Bitcoin Core Project @bitcoincoreorg]

One new high level, and two medium level severity advisories have been added to https://t.co/lMPiJ0Q9Eh

[Bitcoin Core PR Reviews @BitcoinCorePRs]

Next week's review club PR is #30793, "add getorphantxs", authored by tdb3 and hosted by @glozow. This one is designed for beginners - come learn about orphan transactions and adding new RPCs! Notes and questions are up:

https://t.co/IoFIsvVdYK

[Bitcoin Core PR Reviews @BitcoinCorePRs]

In tomorrow's review club meeting, we'll be testing a release candidate for Bitcoin Core v28.0. Come and test some new features with us!

Thank you to rkrux for creating the guide and hosting the meeting. https://t.co/MJdssRciBz

[Bitcoin Core PR Reviews @BitcoinCorePRs]

Next week's review club PR is #30352, "Add PayToAnchor(P2A), OP 1 <0x4e73> as standard output script for spending", authored by @theinstagibbs and hosted by @glozow.

https://t.co/S2vyATuvLY

[Bitcoin Core PR Reviews @BitcoinCorePRs]

Tonight's review club PR is on #30000, "p2p: index TxOrphanage by wtxid, allow entries with same txid", authored and hosted by @glozow. Notes and questions are now available on the website:
https://t.co/O6tsPqRka8

[Bitcoin Core PR Reviews @BitcoinCorePRs]

In next week's review club, we'll test a release candidate for Bitcoin Core v27.0.

cbergqvist, tdb3, davidgumberg, marcofleon put together an extensive Testing Guide.

Do the "Preparation" steps first, and we'll walk through the guide together next Wed!

https://t.co/Kvoyqoe1v7

[Bitcoin Core PR Reviews @BitcoinCorePRs]

This week's review club is #29221, "Implement 64 bit arithmetic op codes in the Script interpreter", authored and hosted by @Chris_Stewart_5 . Check out the extensive notes linked below. See you on IRC on wednesday!

https://t.co/4DMqk6IvTg

[Bitcoin Core PR Reviews @BitcoinCorePRs]

Next week's review club is bitcoin-inquisition PR #45, "LNHANCE inquisition (CSFS, INTERNALKEY)", authored and hosted by @reardencode. Notes and questions are up:

https://t.co/DAY8wYu1dF

[Bitcoin Core PR Reviews @BitcoinCorePRs]

This week's review club is bitcoin-inquisition PR #39, "Re enable OP_CAT". Join us on IRC to learn about the script interpreter code, discuss the implementation approach, and review the tests together!

https://t.co/WaHrWjexQb

[Bitcoin Core PR Reviews @BitcoinCorePRs]

Reminder: we are meeting tomorrow to talk about #28950! Notes and questions to help you prepare 👇

[Bitcoin Core PR Reviews @BitcoinCorePRs]

Next week's review club PR is #28950, "Add maxfeerate and maxburnamount args to submitpackage", authored by @theinstagibbs and hosted by @sadeeq_ismaela. Come nerd out with us on IRC at 17UTC!

Notes are up: https://t.co/Xt0wMjRFn7