Why do some people take code reviews as an attack?
Code reviews are a good tool to express different ideas for implementation, or to discuss something that was potentially misunderstood, or to catch bugs, in any way you learn and grow, so it's a win-win.
I just passed one full-day off maintaining the sonata-projects repositories and there is still work to do.
Be aware those libs (like SonataAdminBundle) are now mainly maintained by 1-2 persons only. If you don't want them to be abandoned, consider:
- Contributing
- Sponsoring me
Ask an engineer to review 5 lines of code; he'll find 20 issues.
Ask him to review 500 lines, and they’ll say it looks good.
When you see a large PR, don't review it; ask to have it broken up into smaller ones.
No, don't use traits, use interfaces and composition for reusable code. Traits are terrible in maintenance, and even worse for static analysis.
They bring the illusion of flexibility with a huge maintenance cost.
This is not how you should build reusable code, I have beed doing this for 16 years already. #PHP #CodeReuse
I am great fan of code reviews, both as a reviewer and as an author of changes. The second pair of eyes is always an added value, if done well. What does "well" mean in this case? You can read about it here: https://t.co/iOhPInz8vK ☺️.
Something super weird happening right now: just been called by several totally different media outlets in the last few minutes, all with Windows machines suddenly BSoD’ing (Blue Screen of Death). Anyone else seen this? Seems to be entering recovery mode:
Laravel is becoming the new Wordpress of PHP
Extremely large user base, turnkey solutions for a variety of problems, detached from the rest of PHP communities, socials flooded with basic tutorials for everything, good to start and then with $$$ will be migrated to something else
If anyone has a connection to the Royal Prince Alfred hospital in Sydney or neuro oncologists anywhere that could help direct me to crack these, please, please let me know. We’re going to war, but I need to connect with the experts to help.
@olegandreyev my fear is that in less than a year per job, you do not learn the "cost of your own mistakes" (that imo is one of the most important learnings as software engineer).