Tong Mu

"DKWings" | @FlutterDev SWE and love it | Former React frontend | 坦诚，豁达，随遇而安

[Tong Mu @DKWmt]

@jpohhhh The transparent pixels are interesting. I’ll greatly appreciate it if you open an issue on Github with a reproduction app!

[Tong Mu @DKWmt]

@jezell @jpohhhh Thank you very much for tagging!

[Tong Mu @DKWmt]

@jpohhhh This bug looks like the one fixed by https://t.co/dgrMGj22n9, which has been landed in 3.42. (not on stable yet)

[Tong Mu @DKWmt]

@imadetheseworks The merging shape is amazing!

[Tong Mu @DKWmt]

@mahersafadii @imadetheseworks @sethladd Yep! Feel free to drop me a DM on X or discord.

[Tong Mu @DKWmt]

@mahersafadii Slightly correction: It’s not because the PR is massive, but the project is massive. Sometimes changes of small LOC can have massive impact and thus must be discussed thoroughly, for example bumping the minimal version of Android. Similar for this one.

[Tong Mu @DKWmt]

@jezell @mahersafadii the PR out of agreement instead of tiredness.

[Tong Mu @DKWmt]

@jezell @mahersafadii Splitting into smaller PRs and steps is also for the convenience of reviewing. Writing something new is hard, and reviewing them is even harder, because reviewers are the last guardians of code correctness. It’s important that reviewers really approve (cont.)

[Tong Mu @DKWmt]

@jezell @mickrich384 @mahersafadii We had to write pages of design docs as well. And it’s becaude they really help. I wrote design docs for almost all big projects of mine, and I only regret the cases when I did not write enough - the keyboard was not discussed thoroughly and admittedly it didnt turn out well

[Tong Mu @DKWmt]

@luckythehusky 很显然审核代码是比编写代码要更难、更基础、更核心的

[Tong Mu @DKWmt]

@RydMike @mahersafadii @luke_pighetti In my algorithm, assume it has equal x radii and y radii, if 2 r_x >= width, then the width sides are circular arcs. The y sides continue to be continuous rounded borders. (Basically the x and y sides are separated/stitched together.) I'm pretty sure this is how Swiftui works.

[Tong Mu @DKWmt]

@luke_pighetti @mahersafadii @RydMike During my research I indeed used screenshots of SwiftUI's shapes as reference and derived the formula by pixel comparison. The theoretical result is pretty good (see attached). The PR, though, focus on the practical side, i.e. how it runs in real apps and can be used by users :)

[Tong Mu @DKWmt]

@HarrySild @RydMike I’m still unsure where the bottleneck is in the Figma Bezier implementation. But yes performance was probably a reason.

[Tong Mu @DKWmt]

@RydMike @HarrySild I did! :)

[Tong Mu @DKWmt]

@luckythehusky 台湾的标准不可靠了，他们的规定本来就跟大陆有差别，他们的字典是真的把“和”读作hàn的

[Tong Mu @DKWmt]

@ll12142_A 祝贺！！

[Tong Mu @DKWmt]

@elct9620 @DeltonDing Weekly Review meeting骂的声音其实挺大的，而且我很难想象怎么scale